RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v7]

Emanuel Peter epeter at openjdk.org
Mon Jan 29 10:24:40 UTC 2024


On Mon, 29 Jan 2024 10:17:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change preconditions for test_divc and test_divc_n
>
> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 547:
> 
>> 545:                    IRNode.VECTOR_SIZE + "min(max_int, max_long)", "> 0" },
>> 546:         applyIfCPUFeature = {"sse2", "true"},
>> 547:         applyIfAnd = {"UseAVX", ">= 2", "UseSSE", ">= 4"})
> 
> Looks like you should just require `avx2`, instead of `sse2`. Then you can drop the `UseAvx` and `UseSSE` flag checks.

If you set a lower AVX/SSE level, then the cpu-features are automatically removed. And if you have a cpu that does not have the relevant features, the AVX/SSE flags are automatically lowered. But in IR tests, we generally try to rely on the features as much as possible, and not the flags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1469377081


More information about the hotspot-compiler-dev mailing list