RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v7]

Daniel Lundén dlunden at openjdk.org
Mon Jan 29 10:30:39 UTC 2024


On Mon, 29 Jan 2024 10:21:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 547:
>> 
>>> 545:                    IRNode.VECTOR_SIZE + "min(max_int, max_long)", "> 0" },
>>> 546:         applyIfCPUFeature = {"sse2", "true"},
>>> 547:         applyIfAnd = {"UseAVX", ">= 2", "UseSSE", ">= 4"})
>> 
>> Looks like you should just require `avx2`, instead of `sse2`. Then you can drop the `UseAvx` and `UseSSE` flag checks.
>
> If you set a lower AVX/SSE level, then the cpu-features are automatically removed. And if you have a cpu that does not have the relevant features, the AVX/SSE flags are automatically lowered. But in IR tests, we generally try to rely on the features as much as possible, and not the flags.

OK, thanks, good to know. I'll make the update. @eme64: Do you want to create a new issue to investigate why it does not vectorize on aarch64? Or maybe that's expected?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1469384442


More information about the hotspot-compiler-dev mailing list