RFR: JDK-8322648: Improve class initialization barrier in TemplateTable::_new for PPC [v3]
Martin Doerr
mdoerr at openjdk.org
Mon Jan 29 15:27:47 UTC 2024
On Mon, 29 Jan 2024 15:07:23 GMT, Varada M <varadam at openjdk.org> wrote:
>> ppc port implementation of https://github.com/openjdk/jdk/pull/17006
>>
>> Fastdebug and Release : build and tier1 testing successful.
>>
>> JBS Issue : [JDK-8322648](https://bugs.openjdk.org/browse/JDK-8322648)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>
> 8322648: Improve class initialization barrier in TemplateTable::_new for PPC
Seems like you have missed my previous comment: https://github.com/openjdk/jdk/pull/17518#pullrequestreview-1847895107
I don't think it's correct without that. And please remove the comment "// get instance_size.". It doesn't tell anything which is not obvious.
We should definitely measure performance with -Xint. Maybe even "time java -Xint -version" shows a difference between correct and incorrect code.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17518#issuecomment-1914925878
More information about the hotspot-compiler-dev
mailing list