RFR: JDK-8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java

[Tobias Hartmann]

On Wed, 31 Jan 2024 10:09:16 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple patch to fix test TestRoundVectFloat.java?
> Thanks!
> 
> FYI: This test is not actually tested, need to fix the test applying filter and IR matching rule.

Changes requested by thartmann (Reviewer).

test/hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java line 2:

> 1: /*
> 2:  * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.

test/hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java line 52:

> 50: 
> 51:   @Test
> 52:   @IR(applyIf = {"UseAVX", " > 1"}, counts = {IRNode.ROUND_VF , " > 0 "})

Isn't that node only available if `UseAVX >= 2`?
https://github.com/openjdk/jdk/blob/f0bae7939a61a79f3e07de97451c433e91742069/src/hotspot/cpu/x86/x86.ad#L1501-L1504

-------------

PR Review: https://git.openjdk.org/jdk/pull/17649#pullrequestreview-1853522702
PR Review Comment: https://git.openjdk.org/jdk/pull/17649#discussion_r1472695949
PR Review Comment: https://git.openjdk.org/jdk/pull/17649#discussion_r1472698786