RFR: 8334554: RISC-V: verify & fix perf of string comparison [v3]
Hamlin Li
mli at openjdk.org
Mon Jul 1 09:39:29 UTC 2024
On Mon, 1 Jul 2024 06:25:03 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> misc
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2361:
>
>> 2359: mv(result, false);
>> 2360:
>> 2361: element_compare(a1, a2, result, cnt, tmp1, tmp2, v2, v4, v2, true, DONE, Assembler::m2);
>
> It's not apparent to me why you use m2 here. Can you add a comment?
Agree. I will verify the string equals later soon, in that patch, I will add the comment accordingly based on test result. Here, it's the previous value which I just passed in as explicit value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19825#discussion_r1660762180
More information about the hotspot-compiler-dev
mailing list