RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Vladimir Kozlov]

On Tue, 25 Jun 2024 23:49:27 GMT, Dean Long <dlong at openjdk.org> wrote:

>> 8321509: False positive in get_trampoline fast path causes crash
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

Restoring performance check in `NativeCall::destination()` was enough for leyden to work (PetClininc with one- and five-steps workflows):

  address NativeCall::destination() const {
    address addr = instruction_address();
    address destination = addr + displacement();

+   // Performance optimization: no need to call find_blob() if it is a self-call
+   if (destination == addr) {
+     return destination;
+   }


@dean-long , I think it should be added in your changes.

@adinn, I suggest you to test these changes with leyden changes for stubs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2206964597