RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Dean Long]

On Tue, 9 Jul 2024 18:42:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> My concern with simply returning raw address when it is not nmethod could be incorrect for Leyden case when we process CodeBuffer which contains code layout similar to nmethod and we can have trampoline call.

Yes, I had the same concern initially.  But there is no way to connect the stub owner call site to the trampoline stub without calling trampoline_stub_Relocation::get_trampoline_for(), which requires an nmethod.  Even if we tried to support it for CodeBuffers, it would be tricky because the target is PC-relative and the distance between the code section and stub section can change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2218690739