RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Vladimir Kozlov]

On Tue, 25 Jun 2024 23:49:27 GMT, Dean Long <dlong at openjdk.org> wrote:

>> 8321509: False positive in get_trampoline fast path causes crash
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

Okay. So the change I proposed will restore the issue because `cb->code_contains(destination) && is_NativeCallTrampolineStub_at(destination)` may point to incorrect trampoline code after expansion. :(

Looks like for Leyden (in Leyden branch) we need to avoid binding calls even if destination is reachable. So that we only have `destination == addr` case for trampoline calls when we process CodeBuffer.  Looks like we missing an other case for `SCCache::is_on_for_write()` check.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2218856502