RFR: 8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops [v2]

[Vladimir Kozlov]

On Thu, 11 Jul 2024 10:34:13 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/output.cpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Update src/hotspot/share/opto/machnode.hpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>
> @JohnTortugo 
> 
>> This test is intended to "test" a transformation in C2, it won't fail if run in C1, but it won't actually test what's intended for. The flagless option is to make sure that C2 produce an IR graph that will trigger the optimization, same reasoning for all the "CompileCommand" options. I may remove the "vm.bits" part, I included it because of the "-UseCompressedOops".
> 
> The `flagless` requires will just mean that your test is not run if there are flags. So we still rely on the test configuration having some run without additional flags. So your requires seems pointless, especially because your test does not crash without it. Unless your test takes a lot of time and you are trying to conserve runtime.
> 
> About flags: I would just have a second run without any flags.

@eme64  I you fine with current version?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20087#issuecomment-2229242259