RFR: 8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops [v2]

[Emanuel Peter]

On Mon, 15 Jul 2024 19:36:18 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> @JohnTortugo 
>> 
>>> This test is intended to "test" a transformation in C2, it won't fail if run in C1, but it won't actually test what's intended for. The flagless option is to make sure that C2 produce an IR graph that will trigger the optimization, same reasoning for all the "CompileCommand" options. I may remove the "vm.bits" part, I included it because of the "-UseCompressedOops".
>> 
>> The `flagless` requires will just mean that your test is not run if there are flags. So we still rely on the test configuration having some run without additional flags. So your requires seems pointless, especially because your test does not crash without it. Unless your test takes a lot of time and you are trying to conserve runtime.
>> 
>> About flags: I would just have a second run without any flags.
>
> @eme64  I you fine with current version?

@vnkozlov @JohnTortugo I'm not familiar enough with this part of the code, just gave some code style and testing suggestions. I was given something else that has higher priority, so maybe some one else can give the VM changes a review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20087#issuecomment-2230712487