RFR: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword [v2]
Emanuel Peter
epeter at openjdk.org
Thu Jun 13 06:50:27 UTC 2024
> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
>
> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
>
> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
>
> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.
Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge branch 'master' into JDK-8333729-superword-requires
- last file
- Merge branch 'master' into JDK-8333729-superword-requires
- JDK-8333729
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19581/files
- new: https://git.openjdk.org/jdk/pull/19581/files/71a5f37a..2733a868
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19581&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19581&range=00-01
Stats: 18634 lines in 548 files changed: 9821 ins; 7222 del; 1591 mod
Patch: https://git.openjdk.org/jdk/pull/19581.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19581/head:pull/19581
PR: https://git.openjdk.org/jdk/pull/19581
More information about the hotspot-compiler-dev
mailing list