RFR: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword [v2]

[Emanuel Peter]

On Thu, 13 Jun 2024 06:50:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
>> 
>> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
>> 
>> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
>> 
>> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.
>
> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8333729-superword-requires
>  - last file
>  - Merge branch 'master' into JDK-8333729-superword-requires
>  - JDK-8333729

What I am doing now, work in progress:

bash jib.sh configure -- --with-debug-level=fastdebug --with-conf-name=linux-x64-debug-noC2 --with-jvm-features=-compiler2
make hotspot CONF=linux-x64-debug-noC2; make jdk CONF=linux-x64-debug-noC2;

And running all relevant tests:

~/Documents/jtreg/bin/jtreg -va -s -jdk:/oracle-work/jdk-fork2/build/linux-x64-debug-noC2/jdk -javaoptions:"" -J-Djavatest.maxOutputSize=10000000 /oracle-work/jdk-fork2/open/test/hotspot/jtreg/compiler/loopopts/superword/


And then I can add `-XX:+IgnoreUnrecognizedVMOptions` in cases where we are using C2 flags, just as  @vnkozlov suggested.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19581#issuecomment-2165908449