RFR: 8329032: C2 compiler register allocation support for APX EGPRs [v3]

Jatin Bhateja jbhateja at openjdk.org
Mon Jun 17 21:35:10 UTC 2024


On Mon, 17 Jun 2024 16:31:37 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jvmci test failures fixes
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 422:
> 
>> 420:     __ movl(Address(rsi,12), rdx);
>> 421: 
>> 422: #if !defined(PRODUCT) && defined(_LP64)
> 
> Why it is still under `!PRODUCT`?  You need to check if OS supports it in product VM too. Or I missing something?

Idea is to enable the APX support for product builds only after completion of planned features listed in JDK-8329030.

I have moved the check to [appropriate place](https://github.com/openjdk/jdk/pull/19042/files#diff-6ed856c57ddbe33e49883adb7c52ec51ed377e5f697dfd6d8bea505a97bfc5a5R3186)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19042#discussion_r1643452680


More information about the hotspot-compiler-dev mailing list