RFR: 8329032: C2 compiler register allocation support for APX EGPRs [v3]

[Vladimir Kozlov]

On Mon, 17 Jun 2024 21:31:36 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/cpu/x86/vm_version_x86.cpp line 422:
>> 
>>> 420:     __ movl(Address(rsi,12), rdx);
>>> 421: 
>>> 422: #if !defined(PRODUCT) && defined(_LP64)
>> 
>> Why it is still under `!PRODUCT`?  You need to check if OS supports it in product VM too. Or I missing something?
>
> Idea is to enable the APX support for product builds only after completion of planned features listed in JDK-8329030.
> 
> I have moved the check to [appropriate place](https://github.com/openjdk/jdk/pull/19042/files#diff-6ed856c57ddbe33e49883adb7c52ec51ed377e5f697dfd6d8bea505a97bfc5a5R3186)

Thank you for moving `PRODUCT` check and adding comment.

New save/restore methods should be under `#ifdef _LP64`. 32-bit build is broken again because of that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19042#discussion_r1643560772