RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences()

[Roland Westrelin]

On Thu, 20 Jun 2024 13:54:32 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I didn't remove it, I moved it. It's what this:
>> 
>> 
>> The fix I propose for this is to test before pushing on the work list
>> whether a node is a store or not.
>> 
>> 
>> refers to. What we do today is that we push all uses and then filter out those that are not of interest when they are popped. What I propose is to filter out what's not useful before it's pushed so the queue doesn't grow large with nodes that are going to be discarded anyway.
>
> Ok, then I suggest that you at least replace this line with an `assert`. That could also help readability ;)

That's what I did but the assert is where the loop starts not where the line was removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19791#discussion_r1647626261