RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences()

Emanuel Peter epeter at openjdk.org
Thu Jun 20 14:03:12 UTC 2024


On Thu, 20 Jun 2024 13:57:26 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Ok, then I suggest that you at least replace this line with an `assert`. That could also help readability ;)
>
> That's what I did but the assert is where the loop starts not where the line was removed.

Hmm, I did see that. But that is quite far away, and who knows maybe someone in the future breaks that assumption somewhere inside the loop. Therefore, it would be nice and easy to restate that assumption.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19791#discussion_r1647632629


More information about the hotspot-compiler-dev mailing list