RFR: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64 [v2]
Doug Simon
dnsimon at openjdk.org
Fri Jun 21 12:30:25 UTC 2024
On Fri, 21 Jun 2024 12:08:25 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added comment to AMD64.cpuRegisters
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/amd64/AMD64.java line 88:
>
>> 86: public static final Register[] cpuRegisters = {
>> 87: rax, rcx, rdx, rbx, rsp, rbp, rsi, rdi,
>> 88: r8, r9, r10, r11, r12, r13, r14, r15
>
> Hi @dougxc , Thanks for fixing this, a comment over cpuRegisters definition relating to its usage will be helpful.
I added a brief comment. I will leave it for [JDK-8334717](https://bugs.openjdk.org/browse/JDK-8334717) to expand upon this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19824#discussion_r1648893151
More information about the hotspot-compiler-dev
mailing list