RFR: 8326983: Unused operands reported after JDK-8326135 [v2]

[Vladimir Kozlov]

On Fri, 1 Mar 2024 07:39:16 GMT, kuaiwei <duke at openjdk.org> wrote:

>> Remove all unused operands reported by adlc. I'm testing x86_64 and aarch64. So far no failure found in tier1.
>> I tried to clean unused operands for all platform. A special case is immLRot2 in arm, it's not used, but appeared in many todo comments. So I keep it.
>
> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
> 
>   clean for other architecture

Testing build with moved `operand no_rax_RegP` passed. Please update changes with this:

diff --git a/src/hotspot/cpu/x86/x86_64.ad b/src/hotspot/cpu/x86/x86_64.ad
index d43929efd3e..aef3453b0b1 100644
--- a/src/hotspot/cpu/x86/x86_64.ad
+++ b/src/hotspot/cpu/x86/x86_64.ad
@@ -2663,18 +2561,6 @@ operand rRegN() %{
 // the RBP is used as a proper frame pointer and is not included in ptr_reg. As a
 // result, RBP is not included in the output of the instruction either.
 
-operand no_rax_RegP()
-%{
-  constraint(ALLOC_IN_RC(ptr_no_rax_reg));
-  match(RegP);
-  match(rbx_RegP);
-  match(rsi_RegP);
-  match(rdi_RegP);
-
-  format %{ %}
-  interface(REG_INTER);
-%}
-
 // This operand is not allowed to use RBP even if
 // RBP is not used to hold the frame pointer.
 operand no_rbp_RegP()
diff --git a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
index d178805dfc7..0cc2ea03b35 100644
--- a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
+++ b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
@@ -99,6 +99,18 @@ static void z_store_barrier(MacroAssembler& _masm, const MachNode* node, Address
 
 %}
 
+operand no_rax_RegP()
+%{
+  constraint(ALLOC_IN_RC(ptr_no_rax_reg));
+  match(RegP);
+  match(rbx_RegP);
+  match(rsi_RegP);
+  match(rdi_RegP);
+
+  format %{ %}
+  interface(REG_INTER);
+%}
+
 // Load Pointer
 instruct zLoadP(rRegP dst, memory mem, rFlagsReg cr)
 %{

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18075#issuecomment-1974071060