RFR: 8326983: Unused operands reported after JDK-8326135 [v2]

kuaiwei duke at openjdk.org
Mon Mar 4 11:12:05 UTC 2024


On Fri, 1 Mar 2024 23:29:53 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Testing build with moved `operand no_rax_RegP` passed. Please update changes with this:
> 
> ```
> diff --git a/src/hotspot/cpu/x86/x86_64.ad b/src/hotspot/cpu/x86/x86_64.ad
> index d43929efd3e..aef3453b0b1 100644
> --- a/src/hotspot/cpu/x86/x86_64.ad
> +++ b/src/hotspot/cpu/x86/x86_64.ad
> @@ -2663,18 +2561,6 @@ operand rRegN() %{
>  // the RBP is used as a proper frame pointer and is not included in ptr_reg. As a
>  // result, RBP is not included in the output of the instruction either.
>  
> -operand no_rax_RegP()
> -%{
> -  constraint(ALLOC_IN_RC(ptr_no_rax_reg));
> -  match(RegP);
> -  match(rbx_RegP);
> -  match(rsi_RegP);
> -  match(rdi_RegP);
> -
> -  format %{ %}
> -  interface(REG_INTER);
> -%}
> -
>  // This operand is not allowed to use RBP even if
>  // RBP is not used to hold the frame pointer.
>  operand no_rbp_RegP()
> diff --git a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
> index d178805dfc7..0cc2ea03b35 100644
> --- a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
> +++ b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad
> @@ -99,6 +99,18 @@ static void z_store_barrier(MacroAssembler& _masm, const MachNode* node, Address
>  
>  %}
>  
> +operand no_rax_RegP()
> +%{
> +  constraint(ALLOC_IN_RC(ptr_no_rax_reg));
> +  match(RegP);
> +  match(rbx_RegP);
> +  match(rsi_RegP);
> +  match(rdi_RegP);
> +
> +  format %{ %}
> +  interface(REG_INTER);
> +%}
> +
>  // Load Pointer
>  instruct zLoadP(rRegP dst, memory mem, rFlagsReg cr)
>  %{
> ```

updated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18075#issuecomment-1976336819


More information about the hotspot-compiler-dev mailing list