RFR: 8320649: C2: Optimize scoped values [v9]

[Roland Westrelin]

On Mon, 26 Feb 2024 14:04:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   32 bit build fix
>
> src/hotspot/share/opto/callGenerator.cpp line 854:
> 
>> 852: 
>> 853:     // Pattern matches:
>> 854:     // if ((objects = scopedValueCache()) != null) {
> 
> Suggestion:
> 
>     // if (scopedValueCache() != null) {
> 
> You don't use `objects` here, so it just confused me.

I use snippets from the java code for `ScopedValue.get()` in the comments so it's easier to see what's being pattern matched.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1511095016