RFR: 8320649: C2: Optimize scoped values [v9]

Roland Westrelin roland at openjdk.org
Wed Mar 6 13:31:52 UTC 2024


On Mon, 26 Feb 2024 15:22:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   32 bit build fix
>
> src/hotspot/share/opto/compile.cpp line 2352:
> 
>> 2350:   if (failing())  return;
>> 2351: 
>> 2352:     inline_scoped_value_get_calls(igvn);
> 
> Suggestion:
> 
>   inline_scoped_value_get_calls(igvn);
> 
> Indentation was wrong. Was this a result of an IDE correcting the missing braces around the if above?

The indentation in that part of `Compile::Optimize()` is wrong (only a single extra character indentation after opening brace at line 2327) and the indentation for that line is correct... but not in line with the code around it. I changed it but `Compile::Optimize()` is the one that would need to be fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1514485609


More information about the hotspot-compiler-dev mailing list