RFR: 8326983: Unused operands reported after JDK-8326135 [v2]

kuaiwei duke at openjdk.org
Tue Mar 5 06:47:48 UTC 2024


On Mon, 4 Mar 2024 18:18:29 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > I'm not clear about m4 file. How do we use it?
> > The build script of jdk will combine all ad file into one single file and adlc will compile it. So aarch64_vector.ad will be checked as well.
> 
> Aarch64 m4 files are used to manually update .ad files. My concern was that could be overlapped code in m4 files which may overwrite your changes in .ad when someone do such manual update in a future. Fortunately `aarch64_ad.m4` does not have operand definitions so your changes are fine. But `aarch64_vector_ad.m4` has them so if we need to change `aarch64_vector.ad` we need to modify m4 file too.

I checked all 44 removed operands in aarch64 and find none of them in m4 file. I just grep them and only "indOffI" and "indOffL" appeared because of "vmemA_indOffI4" and "vmemA_indOffL4" . So we need not change m4 file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18075#issuecomment-1978064822


More information about the hotspot-compiler-dev mailing list