RFR: 8326983: Unused operands reported after JDK-8326135 [v2]

[Vladimir Ivanov]

On Mon, 4 Mar 2024 18:18:29 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>>> For aarch64 do we need also change _.m4 files? Anything in aarch64_vector_ files?
>>> 
>>> I will run our testing with current patch.
>> 
>> I'm not clear about m4 file. How do we use it?
>> The build script of jdk will combine all ad file into one single file and adlc will compile it. So aarch64_vector.ad will be checked as well.
>
>> I'm not clear about m4 file. How do we use it?
>> The build script of jdk will combine all ad file into one single file and adlc will compile it. So aarch64_vector.ad will be checked as well.
> 
> Aarch64 m4 files are used to manually update .ad files. My concern was that could be overlapped code in m4 files which may overwrite your changes in .ad when someone do such manual update in a future. 
> Fortunately `aarch64_ad.m4` does not have operand definitions so your changes are fine.
> But `aarch64_vector_ad.m4` has them so if  we need to change `aarch64_vector.ad` we need to modify m4 file too.

No need to retract integration request. As the bot reported earlier, you need a Commiter to sponsor the PR. But, please, wait until @vnkozlov confirms that testing results are good.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18075#issuecomment-1980071400