RFR: 8320649: C2: Optimize scoped values [v9]

Roland Westrelin roland at openjdk.org
Wed Mar 6 13:38:50 UTC 2024


On Mon, 26 Feb 2024 15:57:10 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   32 bit build fix
>
> src/hotspot/share/opto/loopPredicate.cpp line 1662:
> 
>> 1660:                                      T_ADDRESS, MemNode::unordered);
>> 1661:   _igvn.register_new_node_with_optimizer(handle_load);
>> 1662:   set_subtree_ctrl(handle_load, true);
> 
> How impossible is it to share code with the similar code in `GraphKit`?

We would need something like what is done for `Phase::gen_subtype_check()` that is move the code out of `GraphKit` and we can't access the `GraphKit` helper methods (`basic_plus_adr()`, `make_load()` etc.) so the result would be less readable that the code in `GraphKit`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1514497015


More information about the hotspot-compiler-dev mailing list