RFR: 8321021: RISC-V: C2 VectorUCastB2X [v3]

[Fei Yang]

On Fri, 8 Mar 2024 12:17:15 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch to add support for some vector intrinsics?
>> Also complement various tests on riscv.
>> Thanks.
>> 
>> ## Test
>> test/hotspot/jtreg/compiler/vectorapi/
>> test/hotspot/jtreg/compiler/vectorization/
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix typo

src/hotspot/cpu/riscv/riscv_v.ad line 3220:

> 3218:   ins_encode %{
> 3219:     BasicType bt = Matcher::vector_element_basic_type(this);
> 3220:     if (is_floating_point_type(bt)) {

Could `bt` (the vector element basic type) be floating point type for `VectorUCastB2X` node? I see our aarch64  counterpart has this assertion: `assert(bt == T_SHORT || bt == T_INT || bt == T_LONG, "must be");` [1]. Same question for `VectorUCastS2X` and `VectorUCastI2X` nodes.

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/aarch64_vector.ad#L3752

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1519263293