RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v2]

[Emanuel Peter]

On Tue, 12 Mar 2024 16:18:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix test by adding the missing inversion
>>   
>>   also excluding negative values for unsigned comparison
>
> src/hotspot/share/opto/subnode.cpp line 1812:
> 
>> 1810:     int cop = cmp->Opcode();
>> 1811:     Node *cmp1 = cmp->in(1);
>> 1812:     Node *cmp2 = cmp->in(2);
> 
> Suggestion:
> 
>     Node* cmp1 = cmp->in(1);
>     Node* cmp2 = cmp->in(2);

Ah, just like @jaskarth already said ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1521764243