RFR: 8321021: RISC-V: C2 VectorUCastB2X [v6]

Fei Yang fyang at openjdk.org
Thu Mar 14 06:55:38 UTC 2024


On Wed, 13 Mar 2024 17:05:41 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch to add support for some vector intrinsics?
>> Also complement various tests on riscv.
>> Thanks.
>> 
>> ## Test
>> test/hotspot/jtreg/compiler/vectorapi/
>> test/hotspot/jtreg/compiler/vectorization/
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused instructions; rename instructions

test/hotspot/jtreg/compiler/vectorapi/reshape/TestVectorCastRVV.java line 32:

> 30: /*
> 31:  * @test
> 32:  * @bug 8259610

You might want to change this bug id.

test/hotspot/jtreg/compiler/vectorapi/reshape/utils/TestCastMethods.java line 373:

> 371:             // to X 64
> 372:             makePair(FSPEC64, ISPEC64),
> 373:             makePair(FSPEC64, ISPEC64, true),

Does it make sense to specify `unsignedCast` to true when one of the operand is of type VectorSpecies<Float/Double>? I don't see test items like this for other targets like aarch64 neon/sve.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1524314068
PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1524313821


More information about the hotspot-compiler-dev mailing list