RFR: 8321021: RISC-V: C2 VectorUCastB2X [v6]

Hamlin Li mli at openjdk.org
Thu Mar 14 09:30:10 UTC 2024


On Thu, 14 Mar 2024 06:47:42 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove unused instructions; rename instructions
>
> test/hotspot/jtreg/compiler/vectorapi/reshape/TestVectorCastRVV.java line 32:
> 
>> 30: /*
>> 31:  * @test
>> 32:  * @bug 8259610
> 
> You might want to change this bug id.

fixed.

> test/hotspot/jtreg/compiler/vectorapi/reshape/utils/TestCastMethods.java line 373:
> 
>> 371:             // to X 64
>> 372:             makePair(FSPEC64, ISPEC64),
>> 373:             makePair(FSPEC64, ISPEC64, true),
> 
> Does it make sense to specify `unsignedCast` to true when one of the operand is of type VectorSpecies<Float/Double>? I don't see test items like this for other targets like aarch64 neon/sve.

Thanks for catching, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1524521620
PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1524521562


More information about the hotspot-compiler-dev mailing list