RFR: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If

[Emanuel Peter]

On Wed, 20 Mar 2024 16:19:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/loopnode.hpp line 1890:
>> 
>>> 1888: 
>>> 1889: // Interface to transform OpaqueLoopInit and OpaqueLoopStride nodes of a Template Assertion Predicate Expression.
>>> 1890: class TransformStrategyForOpaqueLoopNodes : public StackObj {
>> 
>> The name could reflect that it is only for template assertion predicates.
>
> Maybe put it in the scope of `TemplateAssertionPredicateExpression` class? Not sure about this idea yet, just an idea.

Should this not be in `predicates.hpp`, together with its implementations?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18293#discussion_r1532419974