RFR: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If [v2]

Christian Hagedorn chagedorn at openjdk.org
Wed Mar 27 11:34:57 UTC 2024


On Wed, 20 Mar 2024 16:32:14 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Maybe put it in the scope of `TemplateAssertionPredicateExpression` class? Not sure about this idea yet, just an idea.
>
> Should this not be in `predicates.hpp`, together with its implementations?

> Maybe put it in the scope of `TemplateAssertionPredicateExpression` class? Not sure about this idea yet, just an idea.

We also need to know about this class in `DataNodeGraph`. Therefore, we cannot make it an inner class. But I've moved it to `predicates.hpp` which is indeed better suited.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18293#discussion_r1537652316


More information about the hotspot-compiler-dev mailing list