RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v4]

Kangcheng Xu kxu at openjdk.org
Mon Mar 25 16:56:52 UTC 2024


On Wed, 13 Mar 2024 02:05:39 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> This PR resolves [JDK-8327381](https://bugs.openjdk.org/browse/JDK-8327381)
>> 
>> Currently the transformations for expressions with patterns `((x & m) u<= m)` or `((m & x) u<= m)` to `true` is in `BoolNode::Ideal` function with a new constant node of value `1` created. However, this is technically a type-improving (reduction in range) transformation that's better suited in `BoolNode::Value` function.
>> 
>> New unit test `test/hotspot/jtreg/compiler/c2/TestBoolNodeGvn.java` asserting on IR nodes and correctness of this transformation is added and passing.
>
> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update the package name for tests

Sorry for not following up closely. The PR has been updated per review suggested.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18198#issuecomment-2018465455


More information about the hotspot-compiler-dev mailing list