RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v4]

[Kangcheng Xu]

On Tue, 26 Mar 2024 06:33:16 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Done. I'm intentionally using bitwise `&` here so that the compiler doesn't short-circuits on conditions with `&&`.  We wish to test all for correctness.
>
> The indentation is still not right, now it looks like the first `!` might apply to all lines.
> My "short-circuit" you mean exit after checking the first term, rather than evaluating all? Ok, I get that, makes sense.

Fixed indentation (again). On second thought, it doesn't really matter whether `&` or `&&` is used here because all terms will be evaluated regardless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1538785342