RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v6]

[Emanuel Peter]

On Tue, 26 Mar 2024 06:44:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   also renames the class name in @run
>
> test/hotspot/jtreg/compiler/c2/irTests/TestBoolNodeGVN.java line 53:
> 
>> 51:     @Test
>> 52:     @Arguments(values = {Argument.DEFAULT, Argument.DEFAULT})
>> 53:     @IR(failOn = IRNode.CMP_U, phase = CompilePhase.AFTER_PARSING, applyIfPlatform = {"x86", "false"})
> 
> Is the 32bit x86 the only platform that does not support it? An alternative would be to enable the IR rule on all platforms that we know support the unsigned compare.

Otherwise some less well tested platform might not support it, and then they have to fix up this rule later, having less context/understanding and might get things wrong then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1538666550