RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v6]

[Kangcheng Xu]

On Tue, 26 Mar 2024 06:45:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/TestBoolNodeGVN.java line 53:
>> 
>>> 51:     @Test
>>> 52:     @Arguments(values = {Argument.DEFAULT, Argument.DEFAULT})
>>> 53:     @IR(failOn = IRNode.CMP_U, phase = CompilePhase.AFTER_PARSING, applyIfPlatform = {"x86", "false"})
>> 
>> Is the 32bit x86 the only platform that does not support it? An alternative would be to enable the IR rule on all platforms that we know support the unsigned compare.
>
> Otherwise some less well tested platform might not support it, and then they have to fix up this rule later, having less context/understanding and might get things wrong then.

Good point. I know x64 and aarch64 support it for sure, but it looks like RISCV also has supports for it [0][1]. I'm not able to verify this on RISCV for not having access to such a machine.

[0] https://github.com/openjdk/jdk/blob/44549b605a7aad1e3143a4058ef6504a7c04167a/src/hotspot/cpu/riscv/riscv.ad#L8800-L8817
[1] https://github.com/openjdk/jdk/commit/f9795d0d09a82cafb3e79ad8667e505c194d745b

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1538762860