RFR: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If [v2]

[Christian Hagedorn]

On Mon, 25 Mar 2024 14:04:21 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Should this not be in `predicates.hpp`, together with its implementations?
>
>> Maybe put it in the scope of `TemplateAssertionPredicateExpression` class? Not sure about this idea yet, just an idea.
> 
> We also need to know about this class in `DataNodeGraph`. Therefore, we cannot make it an inner class. But I've moved it to `predicates.hpp` which is indeed better suited.

> The name could reflect that it is only for template assertion predicates.

>From the point of usage, yes. But I'm not sure if we should really squeeze "TemplateAssertionPredicates" into the already quite long name. I'm more inclined to leave it as it is. And the good thing is that `OpaqueLoopNodes` already gives a hint that it's connected to template assertion predicates.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18293#discussion_r1537657731