RFR: 8325252: C2 SuperWord: refactor the packset [v4]

[Emanuel Peter]

On Tue, 26 Mar 2024 15:36:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use left/right instead of s1/s2 in some obvious simple places
>
> src/hotspot/share/opto/superword.cpp line 1394:
> 
>> 1392: 
>> 1393: SplitStatus PackSet::split_pack(const char* split_name,
>> 1394:                                 Node_List* pack,
> 
> Just wondering if you also plan to have a separate `Pack` class at some point instead of using `Node_List`? If it's not worth we might still want to use a typedef to better show what the intent is. But that's something for another day.

I will keep that in mind. It could really improve readability. Let's do it in a separate RFE!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18276#discussion_r1541172959