RFR: 8325674: Constant fold across compares [v3]

Joshua Cao duke at openjdk.org
Sun Mar 31 08:15:13 UTC 2024


On Fri, 8 Mar 2024 18:33:53 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/subnode.cpp line 1586:
>> 
>>> 1584:       }
>>> 1585:     }
>>> 1586:   }
>> 
>> This looks like heavy code duplication. Can you refactor this? Maybe a helper method?
>
> I can post a version of this so we can see what it looks like. I actually did this first, but the code got quite ugly.

Pushed changes that combine this. I don't think its better or worse, just different. Open to suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17853#discussion_r1545576059


More information about the hotspot-compiler-dev mailing list