RFR: 8324756: Test vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize is too slow due to dependency verification [v2]

[Aleksey Shipilev]

On Thu, 2 May 2024 12:50:16 GMT, Ian Myers <imyers at openjdk.org> wrote:

>> This change removes dependency verification by passing -XX:-VerifyDependencies in the test.
>> 
>> `vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java` takes 20min to run on linux-x86_64-server-fastdebug:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java
>> CONF=linux-x86_64-server-fastdebug make test   **1412.82s user 15.27s system 115% cpu 20:41.19 total**
>> 
>> 
>> Passing -XX:-VerifyDependencies flag speeds up the run time to 1min:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java TEST_VM_OPTS="-XX:-VerifyDependencies"
>> CONF=linux-x86_64-server-fastdebug make test    **287.27s user 16.19s system 496% cpu 1:01.10 total**
>> 
>> 
>> Adding -XX:-VerifyDependencies to the test file accomplishes the same run time of 1min:
>> 
>> time CONF=linux-x86_64-server-fastdebug make test TEST=vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java
>> CONF=linux-x86_64-server-fastdebug make test   **272.33s user 14.56s system 464% cpu 1:01.75 total**
>
> Ian Myers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   [8324756] Remove dependency verification from vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java

I think you want to add the reversal of https://github.com/openjdk/jdk/commit/2564f0f99866c33d14947609c276a421ce8cc0a2 to this PR as well.

I am not sure we want to run the test with disabled dependency verification, though. It is a compiler test, so we would like to have compiler checking code online as much as possible. Have you explored if this is an issue with Sweeper removal, and if so, if adding GCs help?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19040#issuecomment-2090438866