RFR: 8324756: Test vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize is too slow due to dependency verification [v2]

Ian Myers imyers at openjdk.org
Thu May 9 13:21:55 UTC 2024


On Thu, 2 May 2024 12:57:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ian Myers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   [8324756] Remove dependency verification from vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java
>
> I think you want to add the reversal of https://github.com/openjdk/jdk/commit/2564f0f99866c33d14947609c276a421ce8cc0a2 to this PR as well.
> 
> I am not sure we want to run the test with disabled dependency verification, though. It is a compiler test, so we would like to have compiler checking code online as much as possible. Have you explored if this is an issue with Sweeper removal, and if so, if adding GCs help?

@shipilev I have experimented with adding a periodic GC (every 5 seconds) in a new thread, and it did not affect the run time of the test. It still timed out at `CONF=linux-x86_64-server-fastdebug make test 1371.53s user 14.98s system 112% cpu 20:31.41 total` with the removal of the `-XX:-VerifyDependencies` flag.

I will submit an amended commit with this test removed from the ProblemList.txt.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19040#issuecomment-2102649525


More information about the hotspot-compiler-dev mailing list