RFR: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()

[Emanuel Peter]

On Tue, 7 May 2024 06:23:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> In the `MergeStore` logic, I check the `adr_type()`. But in some rare cases this can be a `nullptr`, I did not expect that.
>> 
>> Exampe: during IGVN, the address is dying, with TOP somewhere in the inputs.
>> 
>>    1 Con === 0 [[ ]] #top
>> 1022 AddP === _ 1 1 41 [[ 1019 1021 ]] !orig=539,[572] !jvms: Test::dMeth @ bci:223 (line 35)
>> 1019 StoreI === 1128 827 1022 1020 [[ 1075 541 1073 574 ]] @int[int:>=0] (java/lang/Cloneable,java/io/Serializable):exact+any *, idx=6; Memory: @null !orig=574,1068 !jvms: Test::dMeth @ bci:227 (line 35)
>> 
>> I now check for `nullptr`.
>
> Looks good!

Thanks @chhagedorn @TobiHartmann for the reviews!
Since this is rather a simple fix and creates a bit of noise in the testing pipeline, I'm already integrating now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19103#issuecomment-2097598560