RFR: 8325520: Vector loads with offsets incorrectly compiled [v6]

[Damon Fenacci]

On Tue, 7 May 2024 12:21:30 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8325520: add store/load masked vector tests
>>  - JDK-8325520: add store/load tests with duplicate offsets
>
> src/hotspot/share/opto/memnode.cpp line 1169:
> 
>> 1167:       // LoadVector/StoreVector need additional checks
>> 1168:       if (st->is_StoreVector()) {
>> 1169:         // Ensure that types match
> 
> To reduce  noise, you could revert these comment changes, up to you.

Right, it was a leftover. Removed.

> src/hotspot/share/opto/memnode.cpp line 3551:
> 
>> 3549:         // Regular store (no offsets or mask)
>> 3550:         } else {
>> 3551:           result = mem;
> 
> Suggestion:
> 
>           assert(Opcode() = Op_StoreVector, "just a plain vector store, no offset or mask");
>           result = mem;
> 
> Turning comments into asserts is preferable I would say.

Good idea! Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1592624106
PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1592629045