RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v13]

[Galder Zamarreño]

On Wed, 8 May 2024 04:31:05 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> The assert doesn't hold, e.g.
>> 
>> 
>> === Output from failing command(s) repeated here ===
>> * For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch:
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  Internal Error (/home/runner/work/jdk/jdk/src/hotspot/share/c1/c1_GraphBuilder.cpp:2031), pid=75212, tid=75244
>> #  Error: assert(!!type->as_instance_klass()->is_interface()) failed
>> #
>> # JRE version: OpenJDK Runtime Environment (23.0) (fastdebug build 23-internal-galderz-306db7459b1316251e36d0eccc3035d11db44889)
>> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 23-internal-galderz-306db7459b1316251e36d0eccc3035d11db44889, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
>> # Problematic frame:
>> # V  [libjvm.so+0x777cd0]  GraphBuilder::invoke(Bytecodes::Code)+0x1200
>> 
>> 
>> Thoughts @rwestrel @dean-long?
>
> Hmmm, the double `!!`... let me fix that and see.

Hmmm, something else is failing now. That's odd, maybe master has updated and is causing this PR to fail now?


#  Internal Error (/Users/runner/work/jdk/jdk/src/hotspot/share/ci/ciMetadata.hpp:88), pid=79328, tid=27395
#  assert(is_instance_klass()) failed: bad cast


I will look into it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17667#discussion_r1593714548