RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v13]

[Galder Zamarreño]

On Wed, 8 May 2024 09:18:59 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Hmmm, the double `!!`... let me fix that and see.
>
> Hmmm, something else is failing now. That's odd, maybe master has updated and is causing this PR to fail now?
> 
> 
> #  Internal Error (/Users/runner/work/jdk/jdk/src/hotspot/share/ci/ciMetadata.hpp:88), pid=79328, tid=27395
> #  assert(is_instance_klass()) failed: bad cast
> 
> 
> I will look into it.

Ah no, that assert comes from `type->as_instance_klass()` call:


  ciInstanceKlass*         as_instance_klass() {
    assert(is_instance_klass(), "bad cast");
    return (ciInstanceKlass*)this;
  }


@rwestrel @dean-long what shall we do here? Do we remove the assert altogether? Does the code need to change for the assert to pass? Any other ideas?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17667#discussion_r1593717682