RFR: 8331993: Add counting leading/trailing zero tests for Integer

Christian Hagedorn chagedorn at openjdk.org
Fri May 10 09:49:28 UTC 2024


On Thu, 9 May 2024 11:09:39 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review the patch adding some test?
> Currently, in hotspot/jtreg/compiler/vectorization/TestNumberOfContinuousZeros.java, there is only tests for Long, not for Integer.
> Thanks.

Otherwise, looks good!

test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 1177:

> 1175:     }
> 1176: 
> 1177:     public static final String COUNTLEADINGZEROS_VI = VECTOR_PREFIX + "COUNTLEADINGZEROS_VI" + POSTFIX;

Would have been better to add `_` like that: `COUNT_LEADING_ZEROS_VI`

But the existing `IRNode` strings for the long versions already miss that. If you want to also fix this here, feel free to do so.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19154#pullrequestreview-2049723864
PR Review Comment: https://git.openjdk.org/jdk/pull/19154#discussion_r1596535655


More information about the hotspot-compiler-dev mailing list