RFR: 8331993: Add counting leading/trailing zero tests for Integer [v2]

Hamlin Li mli at openjdk.org
Fri May 10 14:04:37 UTC 2024


On Fri, 10 May 2024 09:45:18 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename
>
> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 1177:
> 
>> 1175:     }
>> 1176: 
>> 1177:     public static final String COUNTLEADINGZEROS_VI = VECTOR_PREFIX + "COUNTLEADINGZEROS_VI" + POSTFIX;
> 
> Would have been better to add `_` like that: `COUNT_LEADING_ZEROS_VI`
> 
> But the existing `IRNode` strings for the long versions already miss that. If you want to also fix this here, feel free to do so.

Yes, it's more readable. Fixed.
Thanks for your reviewing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19154#discussion_r1596788370


More information about the hotspot-compiler-dev mailing list