RFR: 8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines

Doug Simon dnsimon at openjdk.org
Sat May 11 09:09:11 UTC 2024


On Sat, 11 May 2024 08:04:01 GMT, Dean Long <dlong at openjdk.org> wrote:

>> That's done in `~RetryableAllocationMark`.
>
> Only for the HAS_PENDING_EXCEPTION case.  What about the !h->is_initialized() case?

Good observation - seems like this is an outstanding bug. Can you please address that Yudi.
In practice, I wonder how much this matters as Graal always [clears the object result](https://github.com/oracle/graal/blob/0b61d20b08b1af76bd35cfb673c7be8d33855f51/compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/stubs/ForeignCallSnippets.java#L127) after reading it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19176#discussion_r1597405871


More information about the hotspot-compiler-dev mailing list