RFR: 8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines [v2]

Yudi Zheng yzheng at openjdk.org
Mon May 13 10:32:51 UTC 2024


On Sat, 11 May 2024 09:06:20 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Only for the HAS_PENDING_EXCEPTION case.  What about the !h->is_initialized() case?
>
> Good observation - seems like this is an outstanding bug. Can you please address that Yudi.
> In practice, I wonder how much this matters as Graal always [clears the object result](https://github.com/oracle/graal/blob/0b61d20b08b1af76bd35cfb673c7be8d33855f51/compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/stubs/ForeignCallSnippets.java#L127) after reading it.

Good point

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19176#discussion_r1598245624


More information about the hotspot-compiler-dev mailing list