RFR: 8331311: C2: Big Endian Port of 8318446: optimize stores into primitive arrays by combining values into larger store [v3]

[Richard Reingruber]

On Tue, 14 May 2024 16:15:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - test2BE: big endian version of test2
>>  - Improve make_merged_input_value based on Emanuel's feedback
>
> src/hotspot/share/opto/memnode.cpp line 3313:
> 
>> 3311:     merged_input_value = _store->in(MemNode::ValueIn);
>> 3312:     bool is_true = is_con_RShift(first->in(MemNode::ValueIn), base_last, shift_last);
>> 3313: #endif // VM_LITTLE_ENDIAN
> 
> You could just have local variables for "lo" / "hi", set them depending on big/little endian, and then the logic would be the same for both.

Yeah, that's better. I've done that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19218#discussion_r1601726132