RFR: 8331311: C2: Big Endian Port of 8318446: optimize stores into primitive arrays by combining values into larger store [v4]

[Richard Reingruber]

On Tue, 14 May 2024 16:16:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Eliminate IS_BIG_ENDIAN and always execute both variants
>
> test/hotspot/jtreg/compiler/c2/TestMergeStores.java line 57:
> 
>> 55:     private static final Random RANDOM = Utils.getRandomInstance();
>> 56: 
>> 57:     private static final boolean IS_BIG_ENDIAN = UNSAFE.isBigEndian();
> 
> `static` is very important here, so that the `if` constant fold in the test. Otherwise we don't know if we have the IR rule pass because of the correct branch. Maybe add a comment for that.

Sure. I assumed that is clear to people looking at jit compiler tests :)
I removed `IS_BIG_ENDIAN` again since it wasn't needed anymore with the last comit (3169a3104b7323c4ff6f2714449a7c28025d0bba).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19218#discussion_r1602448193