RFR: 8325520: Vector loads with offsets incorrectly compiled [v11]

Emanuel Peter epeter at openjdk.org
Tue May 21 06:57:06 UTC 2024


On Tue, 21 May 2024 06:48:03 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8325520: update match condition
>
> src/hotspot/share/opto/vectornode.hpp line 979:
> 
>> 977:                                                     idx == MemNode::ValueIn ||
>> 978:                                                     idx == MemNode::ValueIn + 1; }
>> 979:    virtual Node* offsets() const { return in(Offsets); }
> 
> Would be nice to add some `override` keywords here ;)

And also below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1607733685


More information about the hotspot-compiler-dev mailing list